Skip to content

[Win32] Release DPI change callback also on failure #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Sep 4, 2026
+8 −3
Merged

[Win32] Release DPI change callback also on failure #3563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6062,10 +6062,15 @@ private DPIChangeProcessingCallback(Control control, Runnable dpiChangeProcessin
// Has to have TIMERPROC signature, see https://learn.microsoft.com/en-us/windows/win32/api/winuser/nc-winuser-timerproc
Callback callback = new Callback(this, "run", void.class, new Type[] { int.class, int.class, int.class, int.class} );
this.operation = () -> {
if (!control.isDisposed()) {
dpiChangeProcessing.run();
try {
if (!control.isDisposed()) {
dpiChangeProcessing.run();
}
} finally {
// The callback must be released in any case, as callback slots are a
// limited resource and leaking them makes further scheduling fail
callback.dispose();
}
callback.dispose();
};
this.address = callback.getAddress();
}
Expand Down
Loading