Repository navigation
Conversation
|
Heads up: API tools treats adding |
|
All GitHub builds pass now. The Jenkins job timed out twice at ~2h, I think in the native-build stage (this PR touches the cocoa and win32 natives). Could someone re-run it when the native build agents are free? |
|
Please change the natives too. The C part will be auto rebuilt by the CI. |
073fc7b to
5165be9
Compare
|
@akurtakov both points are in:
All GitHub builds are green. The Jenkins run on the current head was aborted again after about 2 hours, like the earlier ones. Could someone re-run it, or let me know if there's anything else on my side? |
None of the natives reads it: each one always creates the platform's default embedded frame class (XEmbeddedFrame, CViewEmbeddedFrame, WEmbeddedFrame), and the GTK native did not declare it at all. SWT_AWT.embeddedFrameClass, whose value was passed as className, is deprecated for removal accordingly. Its Class.forName check is kept, so nothing changes for code that still sets it. Fixes eclipse-platform#3665 Signed-off-by: TCs <green.fuzer@gmail.com>
API tools reports adding @noreference to an existing public field as an
API break ("no longer an API", asking for a major version increment), so
drop the tag and keep the @deprecated(forRemoval = true, since = "2026-12")
deprecation alone.
Signed-off-by: TCs <green.fuzer@gmail.com>
Restore @noreference on SWT_AWT.embeddedFrameClass, as requested in review, and filter the resulting "field is no longer an API" problem (id 338940029) in each binary fragment's .api_filters. Signed-off-by: TCs <green.fuzer@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5165be9 to
f6c9d17
Compare
|
Rebasing on top of master does all you have asked for, I did it now. I would appreciate if you squash all the comments into single commit. |
|
Sorry for the delay! There are so many things ongoing and so less times that PRs easily get lost. |
Fixes #3665.
As you suggested,
initFrameno longer takesclassName. None of the natives ever read it (each one always creates the platform's default embedded frame class), and the GTK native didn't even declare it.SWT_AWT.embeddedFrameClassis now deprecated for removal (since 2026-12), following the API removal process. I kept itsClass.forNamecheck, so nothing changes for code that still sets it. On Cocoa,JDK17_FRAMEwas only used as that default, so it's gone too.Like in #3526, I didn't touch
Library.javaor the binaries -- the C change needs the natives rebuilt. Happy to adjust anything!