Skip to content

Ask before opening projects nested below the selection - #4344

Open
vogella wants to merge 2 commits into
eclipse-platform:masterfrom
vogella:open-nested-projects
Open

Ask before opening projects nested below the selection#4344
vogella wants to merge 2 commits into
eclipse-platform:masterfrom
vogella:open-nested-projects

Conversation

@vogella

@vogella vogella commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #4332. Once Close Project can take the nested modules of a Maven or Gradle root along, Open Project brought back only the root and left the modules closed. The action now asks the mirror question, with Open Selected Only as the default, Open Including Nested, and Cancel, and a Remember my decision toggle stores the answer in a new workspace preference next to the one for closing nested projects. The existing prompt for referenced projects is unchanged. The location matching moves into a small helper shared by both actions, and a new test covers both remembered answers and the two cases that ask nothing.

Builds on the #4332 commit, so it shows both until that one is merged and will be rebased afterwards. Verified locally with the new OpenResourceActionTest and the existing CloseResourceActionTest passing headless.

Close Project closed exactly the selected projects, so a project that
physically contains other projects left those open.

The action now offers to close the nested projects too, in a dialog with
"Close Selected Only" as the default, "Close Including Nested" and
Cancel. A "Remember my decision" toggle stores the answer in a new
workspace preference, shown next to the setting for opening referenced
projects. Nothing is asked when no open project is nested below the
selection. CloseUnrelatedProjectsAction opts out, it already confirms
the projects it computes.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
Close Project can take nested modules along, but Open Project brought
back only the root, so the modules stayed closed. The action now offers
to open them too, with Open Selected Only as the default, and a Remember
my decision toggle backed by a new workspace preference next to the one
for closing. The location matching moves into a helper shared by both
actions.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella
vogella force-pushed the open-nested-projects branch from b075928 to 7d6838e Compare September 2, 2026 23:23
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test Results

   858 files  ± 0     858 suites  ±0   51m 58s ⏱️ + 4m 3s
 8 225 tests + 8   7 982 ✅ + 8  243 💤 ±0  0 ❌ ±0 
20 574 runs  +18  19 904 ✅ +18  670 💤 ±0  0 ❌ ±0 

Results for commit 7d6838e. ± Comparison against base commit 2051a90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant