Close Find/Replace test's Welcome page without leaving it maximized - #4352
Merged
HeikoKlare merged 1 commit intoSep 4, 2026
Conversation
The overlay-in-editor test opens an editor and expects the overlay placed on it to take the focus. Inside a full product on a fresh workspace the workbench shows its Welcome page first, which the test closes beforehand. That page is shown maximized, so closing it leaves the window maximized on a part that is gone. An editor opened afterwards is then never rendered into the window but stays in the rendering engine's limbo, where it is invisible, and nothing inside an invisible widget tree can take the focus. The overlay therefore never received it, and the first test of the class failed wherever a Welcome page exists at all: in the Ant-based build, but neither in the IDE nor via Maven Tycho. Putting the page into standby restores the window's regular layout before the page is closed. As the page does not come back afterwards, closing it once per class rather than before every test is sufficient. The message reported when the focus is missed now also names the control holding it instead, which tells an inactive window, a competing focus request and a widget that could never be focused apart. Fixes eclipse-platform#4349 Assisted-by: Claude Opus 5 <noreply@anthropic.com>
HeikoKlare
marked this pull request as ready for review
September 4, 2026 15:57
Contributor
HeikoKlare
deleted the
fix-4349-findreplace-overlay-test-welcome-page
branch
September 4, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindReplaceOverlayInEditorTestopens an editor and expects the Find/Replace overlay placed on it to take the focus. In a full product on a fresh workspace, the workbench shows its Welcome page first, which the test closes beforehand. That page is shown maximized, so closing it leaves the window maximized on a part that is gone. An editor opened afterwards is never rendered into the window but remains in the rendering engine's limbo, where it is invisible, and nothing inside an invisible widget tree can take the focus. The overlay therefore never received it, and the first test of the class failed.This only happens where a Welcome page exists at all, which is the Ant-based test execution in the full SDK, and neither in the IDE nor via Maven Tycho. Putting the page into standby restores the window's regular layout before the page is closed, which makes the editor render as expected. Since the page does not come back afterwards, closing it once per class instead of before every test is sufficient.
The message reported when the focus is missed now also names the control holding it instead, so that a comparable failure can be told apart from an inactive window or a competing focus request without having to reproduce it first.
To find this, the Jenkins setup was rebuilt locally: the SDK and the automated tests of the failing I-build were installed the way the Ant harness does, and the suite was run through
org.eclipse.test.uitestapplicationwith a fresh workspace, so that the Welcome page is present. The failure reproduced in all 9 runs of the unchanged build and disappeared in all runs with this change.Fixes #4349