Skip to content

Improve UX for file selection in the Common tab #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SougandhS wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

Improve UX for file selection in the Common tab #2817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2019 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -232,7 +232,12 @@ protected void createSharedConfigComponent(Composite parent) {
gd.horizontalSpan = 3;
fLocalRadioButton.setLayoutData(gd);
fSharedRadioButton = createRadioButton(comp, LaunchConfigurationsMessages.CommonTab_S_hared_4);
fSharedRadioButton.addSelectionListener(widgetSelectedAdapter(e -> handleSharedRadioButtonSelected()));
fSharedRadioButton.addSelectionListener(widgetSelectedAdapter(e -> {
handleSharedRadioButtonSelected();
if (fSharedRadioButton.getSelection()) {
fSharedLocationText.setFocus();
}
}));

fSharedLocationText = SWTFactory.createSingleText(comp, 1);
fSharedLocationText.getAccessible().addAccessibleListener(
Expand All @@ -258,7 +263,11 @@ private void createOutputCaptureComponent(Composite parent) {
fFileOutput = createCheckButton(comp, LaunchConfigurationsMessages.CommonTab_6);
fFileOutput.setLayoutData(new GridData(SWT.BEGINNING, SWT.NORMAL, false, false));
fFileOutput.addSelectionListener(widgetSelectedAdapter(e -> {
enableOuputCaptureWidgets(fFileOutput.getSelection());
boolean selection = fFileOutput.getSelection();
enableOuputCaptureWidgets(selection);
if (selection) {
fFileText.setFocus();
}
updateLaunchConfigurationDialog();
}));
fFileText = SWTFactory.createSingleText(comp, 4);
Expand Down Expand Up @@ -343,6 +352,9 @@ private void createInputCaptureComponent(Composite parent){
fInputFileCheckButton.setLayoutData(gd);
fInputFileCheckButton.addSelectionListener(widgetSelectedAdapter(e -> {
handleInputFileButtonSelected();
if (fInputFileCheckButton.getSelection()) {
fInputFileLocationText.setFocus();
}
updateLaunchConfigurationDialog();
}));

Expand Down
Loading