Remove unused internal classes - #2893
Merged
vogella merged 2 commits intoSep 2, 2026
Merged
Conversation
These 14 classes have no remaining references in the platform, JDT, PDE, SWT, equinox or p2 sources, and none are registered from a plugin.xml. XMLContentDescriber is an empty subclass of the API class of the same name in org.eclipse.core.runtime.content, which is the one plugin.xml registers. Both Convert classes are referenced only from an older copy of their own bundle on the build path, not from any source. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 14 internal classes that nothing references any more. Candidates came from a dead-code scan of the platform sources and were then verified with JDT search across the aggregator workspace (platform, JDT, PDE, SWT, equinox and p2 on one build path) plus a grep for extension point registrations, so classes that are only instantiated from a plugin.xml were kept.
Two are worth calling out.
org.eclipse.core.internal.content.XMLContentDescriberis an empty subclass of the API class of the same name inorg.eclipse.core.runtime.content, and the content type extension registers the API class, not this one. The twoConvertclasses had a single reference each, and it came from an older copy of their own bundle on the build path rather than from any source.All seven touched bundles compile locally.