Repository navigation
Remove unused isDir parameter from FileSystemHelper.createSymLink - #3041
Merged
HannesWell merged 1 commit intoOct 25, 2026
Merged
Conversation
createSymLink now uses Files.createSymbolicLink, so the parameter is no longer used. On Windows, the JDK determines whether to create a file or directory link from the existing target. Follow-up to eclipse-platform#1486
Contributor
Contributor
Author
|
@HannesWell If you have some time, please take a look at this follow-up PR for #1486 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSymLinknow usesFiles.createSymbolicLink, so the parameter is no longer used. On Windows, the JDK determines whether to create a file or directory link from the existing target.Follow-up to #1486
Tested by running affected tests (
SymlinkTest,SymlinkResourceTest,LinkedResourceTest,ResourceAttributeTest,WorkspaceTest,Bug_185247_recursiveLinks,Bug_233939) locally on macOS.No callers outside eclipse.platform found.