Skip to content

Ready condition reqs reword - #687

Open
MaciejKaszynski wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:ready-condition-reqs-reword
Open

Ready condition reqs reword#687
MaciejKaszynski wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:ready-condition-reqs-reword

Conversation

@MaciejKaszynski

@MaciejKaszynski MaciejKaszynski commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MaciejKaszynski
MaciejKaszynski marked this pull request as ready for review September 24, 2026 10:45
TimoSteuerwaldETAS
TimoSteuerwaldETAS suggested changes Sep 24, 2026
View reviewed changes
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread tests/integration/complex_monitoring/complex_monitoring.py Outdated
Comment thread tests/integration/complex_monitoring/complex_monitoring.py Outdated
@MaciejKaszynski
MaciejKaszynski force-pushed the ready-condition-reqs-reword branch from ef94a58 to 92dc86e Compare September 28, 2026 14:49
TimoSteuerwaldETAS
TimoSteuerwaldETAS suggested changes Sep 29, 2026
View reviewed changes
Comment thread tests/integration/process_complex_rep_failure/process_complex_rep_failure.py
Comment thread tests/integration/process_crash_monitoring/process_crash_monitoring.py
Comment thread tests/integration/process_fd_leak/process_fd_leak.py Outdated
Comment thread tests/integration/smoke/smoke.py Outdated
@MaciejKaszynski
MaciejKaszynski force-pushed the ready-condition-reqs-reword branch from 2c331df to f488080 Compare September 29, 2026 12:30
@MaciejKaszynski
MaciejKaszynski force-pushed the ready-condition-reqs-reword branch from 82206d5 to 74e8c93 Compare September 30, 2026 12:50
@MaciejKaszynski
MaciejKaszynski force-pushed the ready-condition-reqs-reword branch from 74e8c93 to 80cabd8 Compare September 30, 2026 13:05
NicolasFussberger
NicolasFussberger reviewed Oct 1, 2026
View reviewed changes
Comment thread score/launch_manager/docs/requirements/requirements.rst
The :term:`Launch Manager` shall provide a method for condition check for a path.
The :term:`Launch Manager` shall support a :term:`Ready Condition` that is
satisfied when the :need:`logic_arc_int_op__lifecycle__run` interface
is called.

@NicolasFussberger NicolasFussberger Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday in the lifecycle call we discussed that another logical interface shall be introduced for the report_running() method, as currently only the Lifecycle Application interface is defined.

I think it might then be easier to refer to just Running state

@MaciejKaszynski MaciejKaszynski Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I need to specify which interface I use to get to the running state, and logic_arc_int_op__lifecycle__run links to the "run" lifecycle interface is that not the one?

TimoSteuerwaldETAS
TimoSteuerwaldETAS suggested changes Oct 1, 2026
View reviewed changes

@TimoSteuerwaldETAS TimoSteuerwaldETAS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there is still something popped up. 🙈

Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
@MaciejKaszynski @TimoSteuerwaldETAS
Apply batched suggestions from code review
f183392 
Co-authored-by: Timo Steuerwald <142218678+TimoSteuerwaldETAS@users.noreply.github.com>
Signed-off-by: Maciej Kaszynski <161459353+MaciejKaszynski@users.noreply.github.com>

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — f1833925 Waiting Oct 1, 2026 by MaciejKaszynski via Build and test x86_64-qnx / approval #1157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasFussberger NicolasFussberger NicolasFussberger left review comments
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@TimoSteuerwaldETAS TimoSteuerwaldETAS TimoSteuerwaldETAS requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaciejKaszynski @TimoSteuerwaldETAS @NicolasFussberger