Conversation
…n-report patch Baselibs eclipse-score/baselibs#618 fixed the module_verification_report post_template to include all components and switched baselibs' own docs/verification_report/module_verification_report.rst to generate its report via the shared module_verification_report post_template, keeping the id doc__baselibs_verification_report (the template derives the module id by stripping doc__/_verification_report from the need's own id, so this id is now load-bearing). patches/baselibs/005-rename-manual-verification-report-id.patch is no longer compatible with that: reapplying it would rename the id to doc__baselibs_manual_verification_report, which the template would then misparse as module id baselibs_manual, producing an empty report. - Bump score_baselibs known_good pin to 9216215f3a8468f3487884b472e1f325ef36f92b (main after #618). - Drop patch 005 from known_good.json and regenerate bazel_common/score_modules_target_sw.MODULE.bazel. - Simplify docs/verification_report/modules/baselibs/baselibs_verification_report.rst: it no longer redeclares a document with the (now colliding) id, it just links to the report baselibs itself contributes via its docs bundle mount. - Refresh MODULE.bazel.lock via 'bazel mod deps --lockfile_mode=update'.
antonkri
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
September 23, 2026 09:12
… wrapper Remove docs/verification_report/modules/baselibs/, which only redeclared a redundant document need. Link modules/index.rst directly to /modules/score_baselibs/verification_report/module_verification_report, the report baselibs itself contributes via its docs bundle mount, so clicking "Baselibs" jumps straight to it instead of an intermediate wrapper page.
Contributor
Author
|
Superseded by #355 – rebased #355 onto latest main and cherry-picked these two commits on top (baselibs known_good pin bumped to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
baselibs PR #618 fixed
module_verification_reportto include all components and switched baselibs' owndocs/verification_report/module_verification_report.rstto generate its report via the sharedmodule_verification_reportpost_template (fromscore_docs_as_code), keeping the iddoc__baselibs_verification_report.The
module_verification_reporttemplate derives the module id by stripping thedoc__prefix and_verification_reportsuffix from the need's own id, so this id is now load-bearing.patches/baselibs/005-rename-manual-verification-report-id.patchis no longer compatible with that: reapplying it would rename the id todoc__baselibs_manual_verification_report, which the template would then misparse as module idbaselibs_manual, producing an empty report.The patch also made our own
docs/verification_report/modules/baselibs/baselibs_verification_report.rstredundant/conflicting: it redeclared adocumentneed with the same iddoc__baselibs_verification_reportthat baselibs itself now contributes via its docs bundle mount, and referenced the (now non-existent without the patch)doc__baselibs_manual_verification_reportid.What changed
score_baselibsknown_good pin to9216215f3a8468f3487884b472e1f325ef36f92b(main after #618).005-rename-manual-verification-report-id.patchfromknown_good.jsonand delete the patch file.bazel_common/score_modules_target_sw.MODULE.bazelfromknown_good.json.docs/verification_report/modules/baselibs/baselibs_verification_report.rst: it no longer redeclares the document, it links to the report baselibs itself contributes via its docs bundle mount (modules/score_baselibs/verification_report/module_verification_report).MODULE.bazel.lockviabazel mod deps --lockfile_mode=update.