Brought the NOR mapped sector fix into dev - #92
Merged
fdesbiens merged 3 commits intoSep 25, 2026
Merged
Conversation
The NOR erase search can obtain an obsolete count from the cache or block metadata without scanning the mapping table. It then copied an uninitialized mapped count into candidate state, which GCC could report as maybe-uninitialized. The search now initializes the availability flag and resets the mapped count for each block. It still scans the chosen block before returning a mapped count when one was unavailable. A simulator regression checks a cached block with one obsolete and fourteen mapped sectors. GCC 15 with -O2 -Werror=maybe-uninitialized rejected the base revision and built the change. CMake/Ninja regression tests passed 3/3 in each of the obsolete count cache, combined cache, and default coverage configurations. Not run on hardware. Assisted-by: Codex (GPT-6) <noreply@openai.com>
The mapped-sector initialization fix reached master while dev still used an uninitialized count when obsolete counts came from cache or block metadata. The merge carries the source fix and simulator regression into dev. The cache test keeps dev's existing disclosure comment. GCC 14 CMake/Ninja: 40/40 regression tests passed across ten configurations. Merged coverage reached 1,634/2,402 lines (68.03%) and 1,596/2,439 branches (65.44%). Not run on hardware.
The branch's repository check failed because the dev script mistook two CONTRIBUTING.md sentences for malformed source comments. Merge the corrected dev check into the NOR fix branch so CI evaluates the current integration state. The check and full regression job passed for the script correction. The NOR fix branch's earlier regression job passed before this merge. Assisted-by: Codex (GPT-6) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NOR erase search fix from #83 landed on master while dev still used an uninitialized mapped count when obsolete counts came from cache or block metadata.
Merge the master fix and its simulator regression into dev while preserving dev's newer cache tests.
GCC 14 CMake/Ninja: 40/40 regression tests passed across ten configurations. Merged coverage reached 1,634/2,402 lines (68.03%) and 1,596/2,439 branches (65.44%). Not run on hardware.