Conversation
The Cortex-R5 assembly guarded its execution-profile hooks with only the legacy TX_ENABLE_EXECUTION_CHANGE_NOTIFY symbol. The documented TX_EXECUTION_PROFILE_ENABLE configuration initialized profiling without recording thread or interrupt transitions. I made all AC5, AC6, GNU, Green Hills, and IAR hooks accept both symbols. I also extended the port consistency and GNU/LLVM feature checks to cover the current configuration. All 849 base assembly files and all 219 TX_EXECUTION_PROFILE_ENABLE files passed with GCC 14.2.1 and clang 22.1.0. A CMake/Ninja Cortex-R5 profile build emitted all seven expected hook relocations. Proprietary toolchains were not run. Assisted-by: Codex (GPT-5) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341
I found that the Cortex-R5 assembly guarded every Execution Profile Kit hook with only TX_ENABLE_EXECUTION_CHANGE_NOTIFY. Defining the documented TX_EXECUTION_PROFILE_ENABLE initialized EPK storage but recorded no thread or interrupt transitions.
I made the AC5, AC6, GNU, Green Hills and IAR ports accept both symbols at every hook. I also extended the consistency, GCC and LLVM checks so the documented configuration remains covered.
I ran a CMake/Ninja Cortex-R5 profile build, which produced the expected enter and exit relocations in all seven context objects. GCC 14.2.1 and clang 22.1.0 each assembled 849/849 base files, 259/259 legacy-profile files and 219/219 current-profile files, and the port consistency checks passed. I did not run the proprietary AC5, IAR or Green Hills toolchains.
Assisted-by: Codex (GPT-5) noreply@openai.com