Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 8 additions & 35 deletions packages/vue-vuetify/dev/views/ExampleView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ import examples from '../examples';
import { useAppStore } from '../store';
import { createAjv } from '../validate';

import { Pane, Splitpanes } from 'splitpanes';
import 'splitpanes/dist/splitpanes.css';
import { VPane, VSplitpanes } from '../../src/components';
import { getCustomRenderersForExample } from '../renderers';

const { extendedVuetifyRenderers } = await import('../../src');
Expand Down Expand Up @@ -332,12 +331,11 @@ const handleAction = (action: Action) => {
</v-card-title>
<v-divider class="mx-4"></v-divider>
<div class="json-forms">
<splitpanes
:class="['default-theme', 'splitpanes-vuetify']"
:rtl="appStore.rtl"
<v-splitpanes
class="splitpanes-vuetify"
v-if="appStore.layout === 'demo-and-data'"
>
<pane min-size="20">
<v-pane min-size="20">
<v-card>
<v-card-title>
<v-toolbar flat>
Expand All @@ -348,8 +346,8 @@ const handleAction = (action: Action) => {
<v-divider class="mx-4"></v-divider>
<example-form :state="state" @jsfchange="onChange" />
</v-card>
</pane>
<pane>
</v-pane>
<v-pane>
<v-card>
<v-card-title>
<v-toolbar flat>
Expand Down Expand Up @@ -389,8 +387,8 @@ const handleAction = (action: Action) => {
:editorBeforeMount="registerValidations"
></monaco-editor>
</v-card>
</pane>
</splitpanes>
</v-pane>
</v-splitpanes>

<example-form :state="state" @jsfchange="onChange" v-else />
</div>
Expand Down Expand Up @@ -509,28 +507,3 @@ const handleAction = (action: Action) => {
</div>
</div>
</template>
<style lang="scss" scoped>
:deep(.default-theme) {
&.splitpanes--vertical > .splitpanes__splitter,
.splitpanes--vertical > .splitpanes__splitter {
border-left: 1px solid rgb(var(--v-theme-on-surface-variant));
}

&.splitpanes--horizontal > .splitpanes__splitter,
.splitpanes--horizontal > .splitpanes__splitter {
border-top: 1px solid rgb(var(--v-theme-on-surface-variant));
}

.splitpanes__splitter {
background-color: rgb(var(--v-theme-surface));
&:before,
&:after {
background-color: rgb(var(--v-theme-on-surface-variant));
}
&:hover:before,
&:hover:after {
background-color: rgb(var(--v-theme-on-surface-variant));
}
}
}
</style>
1 change: 1 addition & 0 deletions packages/vue-vuetify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"dayjs": "^1.10.6",
"lodash": "^4.17.21",
"maska": "^2.1.11",
"splitpanes": "^3.1.5",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes splitpanes a hard install requirement for every consumer of the package, including those that never render a mixed type, and there's no peerDependenciesMeta marking it optional. Combined with VSplitpanes.sass re-implementing splitpanes' own base layout CSS (the splitpanes/dist/splitpanes.css import is gone), the package takes on 218 lines that have to track upstream. A maintainer should make that call explicitly, and the README quick start probably needs the new peer added.

"vue": "^3.5.0",
"vuetify": "^3.11.0"
},
Expand Down
Loading
Loading