Repository navigation
Conversation
New `toolCall.askUser.trustModeTimeoutSeconds` setting. When the chat is in trust mode and the user does not answer an ask_user question in time, the tool returns a non-error result that tells the LLM to continue with its best judgment and state its assumptions. The pending editor request is cancelled; clients close the question when the tool call finishes. The remote messenger question result now implements Future, like the jsonrpc4clj request it wraps, so future-cancel also drops its pending entry and the editor request.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem
ask_usertool was always blocking, now it can be configured to timeout when in trust mode.Description
New
toolCall.askUser.trustModeTimeoutSecondssetting. When the chat is in trust mode and the user does not answer an ask_user question in time, the tool returns a non-error result that tells the LLM to continue with its best judgment and state its assumptions. The pending editor request is cancelled; clients close the question when the tool call finishes.The remote messenger question result now implements Future, like the jsonrpc4clj request it wraps, so future-cancel also drops its pending entry and the editor request.
DEV note
ask-questionalways returns theBroadcastMessengerwrapper, soask_usermust cancel that wrapper on timeout, or each timeout leaves a registry entry and a waiting watcher thread.Three possible solutions, first one chosen:
question-resultimplementsFuture(chosen):ask_useronly callsfuture-cancel, and the wrapper keeps the same contract as the jsonrpc4cljPendingRequestthat it wraps.remote.messenger/answer-question!fromask_user: fewer lines, butfeatures/would depend oneca.remotefor the first time, and it fails with test messengers that have no registry.cancel-questionmethod toIMessenger: clean, but it changes the protocol and every messenger and test stub must implement it.