fix: make syslinux download resilient (try multiple locations) - #2
Conversation
… default in Dockerfile
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2ccec9cb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readonly SCRIPT_DIR | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" |
There was a problem hiding this comment.
With Bash, readonly SCRIPT_DIR marks the name immutable immediately, so the following assignment aborts with SCRIPT_DIR: readonly variable; as a result ./scripts/test.sh exits before running any tests (the same split declaration pattern also breaks scripts/clean.sh). Keep the assignment in the readonly declaration or assign first and mark it readonly afterward.
Useful? React with 👍 / 👎.
1 participant
No description provided.