Fix embedded OLE object IDs in subdocuments - #659
Open
aka-debug-jie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When several subdocuments contain embedded Excel objects, the generated DOCX
reuses their VML shape, OLE object, and paragraph anchor identifiers. The
embedded packages and icons remain present, but Word only exposes the first
Worksheet Object action.
Root cause
SubdocComposercopied each subdocument's related parts without normalizingthe identifiers that must be unique in the destination document.
Change
shape/@idand OLEShapeIDvalues togetherObjectIDand case-normalizedw14:anchorIdvaluesValidation
the unfixed baseline
sheet names, relationships, ZIP integrity, and OOXML main parts after the fix
the complete 40-script suite, flake8, wheel/sdist builds, and archive audits
Scope and risks
This change is limited to body-level OLE objects using the sibling VML layout
present in the reported attachment. It does not generalize non-OLE VML ID
deduplication or OLE objects in headers, footers, or footnotes.
Closes #621