Removing deprecated search label - #3458
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation reference updates to 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -236,7 +236,7 @@ Also controls how the `changelog add` command maps GitHub labels to various chan | |||
|
|
|||
| | Setting | Description | | |||
| | ----------------- | ------------------------------------------ | | |||
| | `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search": ":Search/Search"`). | | |||
| | `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search Relevance": ":Search Relevance/Search"`). | | |||
There was a problem hiding this comment.
based on your other change, I think this is wrong
| | `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search Relevance": ":Search Relevance/Search"`). | | |
| | `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search": ":Search Relevance/Search"`). | |
There was a problem hiding this comment.
We want to remove the catch-all "Search" label - you have to be more specific now. "Search" should not map to "Search Relevance" - I just wanted to leave an example in this documentation.
There was a problem hiding this comment.
Fair, the other maps the general Search area to "Search Foundations" - it's the closest to the original purpose. I was concerned that removing it all together would break something.
There was a problem hiding this comment.
ah, reading too fast. will leave this for the others regardless :)
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, this is only docs example with not impact. Trust @jilldoty-elastic knows best which labels are relevant 😸
Tiny change to remove reference to deprecated :Search/Search label.