Repository navigation
ci: address zizmor audit findings - #1252
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXDkyHN47yMnthyeNn9Cr4
Deploying electron-website with
|
| Latest commit: |
7641a49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://530834ba.electron-website.pages.dev |
| Branch Preview URL: | https://ci-zizmor-audit-fixes.electron-website.pages.dev |
dsanders11
approved these changes
Oct 21, 2026
dsanders11
marked this pull request as ready for review
October 21, 2026 04:29
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
I reviewed this PR and didn't find any new bugs. Because the change touches pinned GitHub Actions versioning/comments in CI workflows, a human look would still be worthwhile.
What was reviewed:
- The two
# zizmor: ignore[adhoc-packages]suppression comments added to thenpm install @ electron/fiddle-corelines in audit-docs-version.yml and resolve-pr-release-versions.yml — comment-only change, no functional/security impact. - The version-comment update on the pinned
amannn/action-semantic-pull-requestaction in semantic.yml — confirmed the pinned commit SHA itself is unchanged, only the trailing human-readable version comment was edited. - Confirmed no other pinned SHAs, permissions, or secrets usage were touched anywhere in the diff.
Extended reasoning...
The diff is limited to three GitHub Actions workflow files, adding zizmor-ignore comments for two intentional ad-hoc npm installs and editing a trailing version comment on an already-pinned third-party action SHA; no pinned SHAs, permissions, or secrets were changed. This is a small, low-risk CI metadata change with no new code paths or security-sensitive surface touched, and a human reviewer (dsanders11) already approved it with no outstanding objections in the visible timeline.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXDkyHN47yMnthyeNn9Cr4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXDkyHN47yMnthyeNn9Cr4
MarshallOfSound
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
Description of Change
These workflow changes clear the findings zizmor 1.31 reports for this repo in the org-wide audit. The intentional ad-hoc
npm install @electron/fiddle-coresteps inaudit-docs-version.ymlandresolve-pr-release-versions.ymlare suppressed inline with# zizmor: ignore[adhoc-packages], and theref-version-mismatchinsemantic.ymlis fixed by correcting the version comment on the pinnedamannn/action-semantic-pull-requestSHA fromtag: v5tov6.1.1, which is the tag that SHA actually points to (the pin itself is unchanged).Checklist
Generated by Claude Code