Skip to content

build: bump secret-service-action to v1.1.0 - #1263

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Description of Change

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.

Checklist


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:38

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. The diff is a one-line pin bump, but the action it pins handles the OIDC secret exchange that hands back the PR approver token, so a code owner should still confirm the new SHA.

What was reviewed:

  • The secret-service step in .github/workflows/update-docs.yml is still pinned to a full commit SHA with a version comment, and no inputs are passed to it.
  • The later "Approve and merge" step reads only steps.secret-service.outputs.secrets (falling back to '{}') to get PR_APPROVER_GH_TOKEN. v1.1.0 needs to keep exposing that same output.
  • I couldn't fetch the upstream repo from this session, so I didn't confirm that 23b9042f is the commit tagged v1.1.0 or check how it changed from v1.0.0.
Extended reasoning...

The change is one line in .github/workflows/update-docs.yml. It moves the pin for electron/secret-service-action from the v1.0.0 commit to a commit labelled v1.1.0. That action runs with id-token: write and returns the secret used as the token that approves and merges the automated docs PR, so it is a credential-handling surface. The CODEOWNERS * rule assigns this file to a working group. I also couldn't confirm from this session that the new SHA matches the upstream v1.1.0 tag, and those two facts decided the deferral over an approval.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97a339c
Status: ✅  Deploy successful!
Preview URL: https://2cb73ebb.electron-website.pages.dev
Branch Preview URL: https://bump-secret-service-action-v.electron-website.pages.dev

View logs

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:42
@MarshallOfSound
MarshallOfSound merged commit e2d65e2 into main Oct 22, 2026
9 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants