Repository navigation
build: bump secret-service-action to v1.1.0 - #1263
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. The diff is a one-line pin bump, but the action it pins handles the OIDC secret exchange that hands back the PR approver token, so a code owner should still confirm the new SHA.
What was reviewed:
- The
secret-servicestep in.github/workflows/update-docs.ymlis still pinned to a full commit SHA with a version comment, and no inputs are passed to it. - The later "Approve and merge" step reads only
steps.secret-service.outputs.secrets(falling back to'{}') to getPR_APPROVER_GH_TOKEN. v1.1.0 needs to keep exposing that same output. - I couldn't fetch the upstream repo from this session, so I didn't confirm that
23b9042fis the commit tagged v1.1.0 or check how it changed from v1.0.0.
Extended reasoning...
The change is one line in .github/workflows/update-docs.yml. It moves the pin for electron/secret-service-action from the v1.0.0 commit to a commit labelled v1.1.0. That action runs with id-token: write and returns the secret used as the token that approves and merges the automated docs PR, so it is a credential-handling surface. The CODEOWNERS * rule assigns this file to a working group. I also couldn't confirm from this session that the new SHA matches the upstream v1.1.0 tag, and those two facts decided the deferral over an approval.
Deploying electron-website with
|
| Latest commit: |
97a339c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cb73ebb.electron-website.pages.dev |
| Branch Preview URL: | https://bump-secret-service-action-v.electron-website.pages.dev |
Requested by Samuel Attard · Slack thread
Description of Change
Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.
Checklist
Generated by Claude Code