Feature: Add action to find matching bracket - #1680
Open
jeremypw wants to merge 16 commits into
Open
Conversation
jeremypw
added
the
testing
jeremypw
removed
the
testing
jeremypw
changed the title
# Conflicts: # src/MainWindow.vala # src/Widgets/SourceView.vala
jeremypw
marked this pull request as ready for review
August 9, 2026 15:37
zeebok
approved these changes
Aug 27, 2026
zeebok
left a comment
zeebok
left a comment
Contributor
There was a problem hiding this comment.
Just one optional comment but looks good to me! Excited to make use of this feature!
| var parent_window = get_toplevel () as Gtk.Window; | ||
| var dialog = new Granite.MessageDialog ( | ||
| found ? _("Matching bracket has different indent") : _("No matching bracket found"), | ||
| _("You may have omitted a required bracket or inserted extra brackets between lines %i and %i, or you may need to adjust the indents").printf (min_line, max_line), |
Contributor
There was a problem hiding this comment.
Would it be better to have a similar found ternary op so the full message matches the summary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin highlight matching brackets only works over a limited number of characters. This works over whole document, scrolls to match and checks whether indent is the same.
This action (but not accelerator) is now exposed in the document context menu