Gtk4Prep: ProjectChooserButton#1753
Conversation
| } | ||
| }); | ||
|
|
||
| project_listbox.row_activated.connect ((row) => { |
There was a problem hiding this comment.
Rows can be activated in other ways than just button presses, such as with the keyboard. So we really need to keep this
There was a problem hiding this comment.
Are you sure? The rows are bound to an action now so it doesn't matter how they are activated, the action will fire.
There was a problem hiding this comment.
I don't think itts possible for the checkboxes to get focus and change without activating the row but I'll check.
There was a problem hiding this comment.
Ok, it is possible (though not obvious how) so I'll make the checkbuttons non-focusable.
|
I've fixed it so that it is possible to operate the chooser with the keyboard (once it has been opened) but because of a previously reported css bug (upstream) there is no visible focus on the rows. But the whole issue of keyboard accessibility needs revisiting after the port anyway. |
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This works I think. It looks like we can get into a broken state with the selection so we should probably revisit this after the GTK4 port since we'll have some more flexibility, but I'm happy with this for now :)
Just one little thing that looks like an accident
| * This program is free software: you can redistribute it and/or * it under the terms of the GNU General Public License as published by | ||
|
|
||
| modify * the Free Software Foundation, either version 3 of the License, or |
There was a problem hiding this comment.
Seems like this was an accident?
There was a problem hiding this comment.
Oops! Now fixed. Thanks for spotting.
jeremypw
force-pushed
the
jeremypw/gtk4prep/project-button
branch
from
a7c92ce to
8046464
Compare
3 participants
This should work in Gtk4 with minimal changes for porting purposes.
There are no dead areas when clicking on the listboxrows.