SearchBar: use actions - #1807
Conversation
danirabbit
changed the title
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Everything seems to work as expected. Just a couple of comments about the code.
|
@jeremypw went down the rabbithole of fixing the find_next and find_previous actions and we can save a bunch of keypress handling code as well if we add those actions into the search bar. Let me know if this is getting out of hand and should be done in separate steps |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
This is definitely the way to go and in line with what has already been started in Terminal i.e. move stuff out of MainWindow into the relevant widget where possible.
I made a comment but I will test this further tomorrow as the changes are now more substantial.
|
I'm gonna break up the settings changes to another branch to make it a little more digestible |
danirabbit
changed the title
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
All seems to work.
It feels a little odd duplicating action in SearchBar and MainWindow but I guess that is unavoidable in Gtk3 and still saves some code.
2 participants
Make sure we never use UI as a source of truth. Use actions and set those actions as enabled. Use settings as source of truth where possible