Skip to content

SearchBar: improve settings handling - #1809

Open
danirabbit wants to merge 6 commits into
masterfrom
danirabbit/searchbar-settings-improvements
Open

SearchBar: improve settings handling#1809
danirabbit wants to merge 6 commits into
masterfrom
danirabbit/searchbar-settings-improvements

Conversation

@danirabbit

@danirabbit danirabbit commented Aug 25, 2026

Copy link
Copy Markdown
Member
  • Recycle the same SearchSettings instead of creating a new one and resetting settings every time document changes
  • Use Settings as the source of truth, not widget states

@danirabbit
danirabbit marked this pull request as ready for review August 25, 2026 20:28
@danirabbit
danirabbit requested a review from a team August 25, 2026 20:28
@jeremypw

Copy link
Copy Markdown
Collaborator

@danirabbit After merging master it was necessary to retain a reference to cyclic_search button to get it to compile. You might want to see whether this can avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants