Make search entry primary icon activatable so signal handler works - #1810
Open
jeremypw wants to merge 1 commit into
Open
Make search entry primary icon activatable so signal handler works#1810jeremypw wants to merge 1 commit into
jeremypw wants to merge 1 commit into
Conversation
jeremypw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing code connects to the
icon-releasedsignal and the handler actionsfind-nextif it was the primary icon that was pressed. However this did not work as the primary icon needs to be activatable and sensitive.This PR fixes that.
The icon is now activatable and sensitive when it does not have an error css class