Skip to content

Fix the underlying protocol error regression test - #16066

Open
preciz wants to merge 1 commit into
elixir-lang:mainfrom
preciz:fix/protocol-underlying-error-test
Open

preciz wants to merge 1 commit into
elixir-lang:mainfrom
preciz:fix/protocol-underlying-error-test

Conversation

@preciz

@preciz preciz commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

The "protocol keeps underlying UndefinedFunctionError" test calls WithAll, which no longer exists, so it passes without reaching the protocol implementation.

Call Sample instead and assert that the exception identifies Unknown.undefined/1, the deliberate failure inside the implementation. Remove the obsolete WithAll warning suppression and use apply/3 to avoid the fixture’s deprecation warning.

Assisted-by: Codex CLI:GPT 6.1 Sol

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant