Repository navigation
Conversation
The response fields of a request were reset after an informational response so the final response could be parsed, and that dropped the Connection options of the 1xx response. A "close" option in a 1xx response was ignored, and the connection stayed open for the requests pipelined behind it. RFC 9112 9.6 has a client that receives "close" close the connection after reading the response containing it. A 1xx isn't the complete response, so Mint now keeps the option and closes the connection after the final response, handling it as if the final response carried it: the connection is closed after the final response, including a 101 or an HTTP/1.0 keep-alive one, and queued requests fail with :unprocessed. A 2xx response to CONNECT still keeps the connection open for the tunnel. Other Connection options of a 1xx response, such as keep-alive, don't apply to the final response.
ericmj
added this pull request to stack #530
October 16, 2026 13:03
Coverage Report for CI Build 205Coverage decreased (-0.05%) to 90.469%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response fields of a request were reset after an informational response so the final response could be parsed, and that dropped the Connection options of the 1xx response. A "close" option in a 1xx response was ignored, and the connection stayed open for the requests pipelined behind it.
RFC 9112 9.6 has a client that receives "close" close the connection after reading the response containing it. A 1xx isn't the complete response, so Mint now keeps the option and closes the connection after the final response, handling it as if the final response carried it: the connection is closed after the final response, including a 101 or an HTTP/1.0 keep-alive one, and queued requests fail with
:unprocessed. A 2xx response to CONNECT still keeps the connection open for the tunnel. Other Connection options of a 1xx response, such as keep-alive, don't apply to the final response.