Repository navigation
Conversation
The client :max_header_list_size setting is always an integer: it defaults to 256 KB, and the validation in connect/4 and put_settings/2 raises an ArgumentError for any other value, including :infinity. The branches that handled an :infinity client value when measuring decoded header lists and buffered header blocks could never run, so they're removed. The server's SETTINGS_MAX_HEADER_LIST_SIZE is still :infinity until the server sends it, and its handling is unchanged. Tests pin the validation that rejects :infinity for the client setting in connect/4 and put_settings/2.
ericmj
added this pull request to stack #537
October 16, 2026 13:04
Coverage Report for CI Build 0Coverage increased (+0.2%) to 90.805%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client
:max_header_list_sizesetting is always an integer: it defaults to 256 KB, and the validation inconnect/4andput_settings/2raises an ArgumentError for any other value, including:infinity. The branches that handled an:infinityclient value when measuring decoded header lists and buffered header blocks could never run, so they're removed. The server's SETTINGS_MAX_HEADER_LIST_SIZE is still:infinityuntil the server sends it, and its handling is unchanged.Tests pin the validation that rejects
:infinityfor the client setting inconnect/4andput_settings/2.