Repository navigation
Conversation
RFC 9113 8.4 only lets a server push responses for origins it's authoritative for. Mint doesn't check the pushed :scheme and :authority, so the server push docs now say to compare them with the connection's origin before using a pushed response and to cancel the promised request with cancel_request/2 if they don't match. The example of promised headers also lists :scheme and :authority, which promised requests always include.
ericmj
added this pull request to stack #537
October 16, 2026 13:04
Coverage Report for CI Build 0Coverage increased (+0.4%) to 91.004%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113 8.4 only lets a server push responses for origins it's authoritative for. Mint doesn't check the pushed
:schemeand:authority, so the server push docs now say to compare them with the connection's origin before using a pushed response and to cancel the promised request withcancel_request/2if they don't match.The example of promised headers also lists
:schemeand:authority, which promised requests always include.