Skip to content

Treat 2xx responses to CONNECT as tunnels in the HTTP/2 fuzz model #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericmj wants to merge 1 commit into from
Open

Treat 2xx responses to CONNECT as tunnels in the HTTP/2 fuzz model #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/mint/http2/fuzz_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,8 @@ defmodule Mint.HTTP2.FuzzTest do
end

# RFC 9113 8.1.1: the body must match a valid content-length, and responses to
# HEAD, 204 and 304 responses have no content.
# HEAD, 204 and 304 responses have no content. A 2xx response to CONNECT opens a
# tunnel and the DATA after it is tunnel data (RFC 9110 9.3.6, RFC 9113 8.5).
defp update_meta(meta, {:status, ref, status}, _ref_state, _state) when is_map_key(meta, ref) do
put_in(meta[ref].status, status)
end
Expand All @@ -642,16 +643,16 @@ defmodule Mint.HTTP2.FuzzTest do
%{method: method, status: status, content_length: content_length, body_size: body_size} =
meta[ref]

bodiless? = method == "HEAD" or status in [204, 304]
tunnel? = method == "CONNECT" and status in 200..299
bodiless? = method == "HEAD" or (status in [204, 304] and not tunnel?)

cond do
bodiless? and body_size > 0 ->
flunk(
"#{method} #{status} response completed with #{body_size} body bytes\n#{describe(state)}"
)

not bodiless? and content_length != nil and body_size != content_length and
not (method == "CONNECT" and status in 200..299) ->
not bodiless? and not tunnel? and content_length != nil and body_size != content_length ->
flunk(
"response completed with #{body_size} body bytes but content-length #{content_length}\n#{describe(state)}"
)
Expand Down
Loading