Repository navigation
Conversation
The model seeded the server's view of the connection window from Mint's own receive_window_remaining, so a client that kept a 16,777,216-byte window internally without sending the WINDOW_UPDATE that announces it went unnoticed. The view now starts at the 65,535-byte initial window (RFC 9113 section 6.9.2) and only grows by the stream 0 WINDOW_UPDATE frames the test server decodes from what Mint writes, starting with the one that may follow the client preface. The preface is still required to be a SETTINGS frame followed by at most that WINDOW_UPDATE, and anything else fails the scenario before it runs.
ericmj
added this pull request to stack #544
October 16, 2026 13:10
Coverage Report for CI Build 5677Coverage decreased (-0.2%) to 90.508%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions6 previously-covered lines in 2 files lost coverage.
Coverage Stats
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model seeded the server's view of the connection window from Mint's own
receive_window_remaining, so a client that kept a 16,777,216-byte window internally without sending the WINDOW_UPDATE that announces it went unnoticed. The view now starts at the 65,535-byte initial window (RFC 9113 section 6.9.2) and only grows by the stream 0 WINDOW_UPDATE frames the test server decodes from what Mint writes, starting with the one that may follow the client preface. The preface is still required to be a SETTINGS frame followed by at most that WINDOW_UPDATE, and anything else fails the scenario before it runs.