fix: apply lint categories to type-aware checks - #41
Draft
romankurakin wants to merge 1 commit into
Draft
romankurakin wants to merge 1 commit into
romankurakin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volt removes category filters before invoking the type-aware runner. A configuration such as
rules: %{"correctness" => :deny}therefore does not enabletypescript/no-floating-promisesunless the rule is also listed explicitly.Pass categories and enabled plugins to OXC after resolving per-file overrides. OXC expands the categories using its native registry. When
tsgolintrejects an unsupported rule, explicitly disable it before retrying so category expansion cannot select it again.This PR depends on the category support proposed in elixir-volt/oxc_ex#7 and a corresponding OXC release.
Closes #40.