fix: restore recipe parser import - #118
Merged
srpatcha merged 1 commit intoSep 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly restores the public import path while preserving compatibility, and includes a direct regression test for the aliasing contract.
Pull request overview
This PR restores a public parse_recipe entry point in ebuild.packages.recipe while preserving the historical _parse_recipe name for backward compatibility, and adds a regression test to ensure both names remain available.
Changes:
- Rename the internal parser function to the public
parse_recipe. - Keep
_parse_recipeas a compatibility alias to the public parser. - Add a test asserting
_parse_recipeandparse_reciperefer to the same callable.
File summaries
| File | Description |
|---|---|
ebuild/packages/recipe.py |
Exposes parse_recipe as the primary API while retaining _parse_recipe as a backward-compatible alias. |
tests/ebuild/test_package_recipe.py |
Adds a regression test to ensure the legacy alias still resolves to the public parser. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
srpatcha
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification