fix: install EoSim from the pinned tag in the Windows and macOS sanity jobs - #121
Draft
srpatcha wants to merge 1 commit into
Draft
fix: install EoSim from the pinned tag in the Windows and macOS sanity jobs#121srpatcha wants to merge 1 commit into
srpatcha wants to merge 1 commit into
Conversation
…y jobs Opened by the scheduled autoreview pipeline after review of open PRs. Reviewed against the EmbeddedOS Master Design v2.0. Files: .github/workflows/eosim-sanity.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EoSim Sanityhas two red jobs on every nightly run. In the most recent run(34436907943)
20 of 22 jobs passed and exactly two failed: Windows Sanity and macOS Sanity.
Both die on their first command:
Root cause
.github/workflows/eosim-sanity.yml:116and:132install EoSim from a releasewheel asset:
pip install "eosim @ https://github.com/embeddedos-org/EoSim/releases/download/v${{ env.EOSIM_VERSION }}/eosim-${{ env.EOSIM_VERSION }}-py3-none-any.whl"embeddedos-org/EoSimdoes not publish wheels. Thev1.5.0release carries oneasset,
EoSim_v1.5.0_promo.mp4;v3.0.1likewise carries onlyEoSim_v3.0.1_promo.mp4. No release in the repository has ever attached a.whl, so this URL cannot resolve for any value ofEOSIM_VERSION— bumpingthe version would not help.
The other three jobs in this same workflow —
install-validate(9 legs acrossUbuntu, Windows and macOS),
nested-simulationandnested-guest-install—already install by cloning the tag (
:38,:69,:97) and all pass, includingthe three Windows legs and the three macOS legs. Only these two jobs were left
on the wheel URL.
The fix
Give
windows-sanityandmacos-sanitythe sameInstall EoSim from sourcestep the passing jobs use, and leave their existing assertions untouched:
The
/tmp/EoSimpath is used verbatim rather than a Windows-native path becauseinstall-validatealready clones to exactly that path onwindows-latestandthose legs are green.
Files changed
.github/workflows/eosim-sanity.yml— two jobs, install step only.Expected impact
The two failing jobs get a working EoSim, so their
eosim --version,eosim listandeosim doctorassertions actually run instead of aborting atinstall. Nothing else in the workflow changes.
Risks and compatibility
Low. Workflow-only; no product code, no public interface, no dependency change.
The change makes two jobs behave like nine jobs that already pass on the same
runner images.
Two things this PR deliberately does not do, recorded so they are not
mistaken for fixed:
sanity-gate(:154) exitsnon-zero only when
install-validatefails;windows-sanity,macos-sanity,nested-simulationandnested-guest-installresults areprinted and ignored. Run 34436907943 therefore reported
✅ All EoSim sanity checks passedwith two jobs red. That is a separatedefect in the same file and belongs in its own change rather than mixed into
an install fix.
eosim listasserts nothing. Observed while verifying this change:eosim listprintsAvailable platforms (0)and exits 0, even thougheosim doctorreportsTotal platforms 149in the same session. The stepsnamed "Validate all platform configs" cannot fail on an empty list. Also out
of scope here.
Evidence
.ai/autoreview/state/maint/20260910T000629/ebuild.md§"CI — latest run on master" (
failure EoSim Sanity).gh release view v1.5.0 --repo embeddedos-org/EoSim --json assets.Verification
Executed in an isolated worktree branched from
origin/master:eosim-install/tmp/eosim_install_check.shyamllint/tmp/eosimv/bin/yamllint -c .yamllint.yml .github/workflows/eosim-sanity.ymlOpened by the scheduled autoreview pipeline (model
claude-opus-5), branched fromorigin/master. No human has reviewed this yet. Close it freely if the fix is wrong - a bad automated PR is a bug worth reporting.