Repository navigation
fix(core): keep DASHCOMMERCE_VERSION in sync with package.json - #35
Merged
Merged
Conversation
Changesets version PRs bump package.json but left the hardcoded plugin descriptor constant behind, so the version-constant CI check failed on main after #27 (0.2.1 vs 0.2.0). Import the version from package.json so tsdown inlines it at build time and future Version Packages bumps cannot drift. Co-authored-by: Timchosen Uzua <timchosen@gmail.com>
cavewebs
marked this pull request as ready for review
October 6, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After Version Packages (#27),
@dashcommerce/coreis0.2.1inpackage.jsonbutDASHCOMMERCE_VERSIONinpackages/core/src/index.tswas still"0.2.0". That failspackages/core/test/version-constant.test.tson main.Changesets only bumps
package.json. The hardcoded constant did not move with it.Fix
Source
DASHCOMMERCE_VERSIONfrompackage.json(import pkg from "../package.json"). tsdown inlinesversionintodist/index.jsat build time, so the published descriptor matches the package and future Version Packages PRs cannot drift.The existing version-constant CI step remains as the backstop.
No changeset, no publish, no EmDash peer / PaymentProvider / advisory changes.
Test
bun test packages/core/test/version-constant.test.ts— pass (0.2.1)package.jsonbump to9.9.9— test still passed without touching the constantbun run --cwd packages/core test— 123 passbun run typecheck— pass