Repository navigation
fix(ci): stop Release from painting main red after version PRs - #38
Merged
Merged
Conversation
The Release workflow still ran changeset publish after Version Packages merges. Actions NPM_TOKEN cannot publish @dashcommerce/* (npm E404), so main showed red even when CI was green. Keep Changesets Version Packages PRs; ship npm locally. Co-authored-by: Timchosen Uzua <timchosen@gmail.com>
cavewebs
marked this pull request as ready for review
October 7, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After Version Packages #37 (
@dashcommerce/core@0.2.2), CI is green onmainbut Release is red. npm is shipped locally (npm publish --access publicfrompackages/core); Actions is not a working publisher.Verified on Release run 37460919491 (and the same pattern on #27):
changesets/actionlogsNo changesets found. Attempting to publish any unpublished packages to npm..npmrcfromNPM_TOKENand runsbun run release→changeset publish.E404 Not Found - PUT https://registry.npmjs.org/@dashcommerce%2fcore— the usual failure when the token cannot publish the scope. The secret is present but unusable, not missing (so anif: secrets.NPM_TOKEN != ''skip would still run and fail).Pushes that only open/update a Version Packages PR stay green. Merging that PR is what turns
mainred.Change
Small, reversible cut of the broken Actions publish path:
Releaseonpushtomain.changesets/actionwithoutpublish:, so it still opens/updates Version Packages PRs and exits 0 when there is nothing to version.NPM_TOKEN,NPM_CONFIG_PROVENANCE,id-token: write,registry-url, andcreateGithubReleases(all publish-only)..changeset/README.md.bun run releasein rootpackage.jsonis unchanged for anyone who wants to publish from a logged-in machine.Not in this PR
NPM_TOKENrefresh/rotation.Reverse
Restore
publish: bun run release,NPM_TOKEN, and provenance on thechangesets/actionstep if Actions npm auth is ever wired up for real.After merge
The next
mainpush runs Release withoutchangeset publish, so the default branch check should go green. Version Packages PRs keep working the same way; npm still ships locally.