Allow environment variables in config strings. NFC - #27215
Merged
Conversation
sbc100
force-pushed
the
config_vars_expand
branch
3 times, most recently
from
June 30, 2026 19:52
bd44323 to
830e0a5
Compare
sbc100
changed the title
sbc100
force-pushed
the
config_vars_expand
branch
from
June 30, 2026 20:22
830e0a5 to
88e1a2a
Compare
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 18:47
88e1a2a to
5f85467
Compare
sbc100
force-pushed
the
config_vars_expand
branch
2 times, most recently
from
July 20, 2026 18:55
41baab6 to
18b03a3
Compare
kripken
reviewed
Jul 20, 2026
kripken
reviewed
Jul 20, 2026
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 20:26
18b03a3 to
8c92375
Compare
sbc100
added a commit
that referenced
this pull request
Jul 20, 2026
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 20:35
8c92375 to
e50fb3a
Compare
kripken
reviewed
Jul 20, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
lgtm, but do we need a changelog mention? Perhaps there are paths that now expand into something different than before?
sbc100
force-pushed
the
config_vars_expand
branch
2 times, most recently
from
July 20, 2026 20:50
e4ee4a7 to
1dd2387
Compare
Collaborator
Author
|
Added ChangeLog entry. |
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 20:51
1dd2387 to
3975862
Compare
kripken
reviewed
Jul 20, 2026
kripken
approved these changes
Jul 20, 2026
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 21:53
3975862 to
0d5ffc5
Compare
sbc100
enabled auto-merge (squash)
July 20, 2026 22:13
This allows us to avoid doing things like `os.path.expanduser` and `os.path.expandvars` inside the config files themselves. This helps pave the way to one day making the config files plain text rather than python scripts. See emscripten-core#27219
sbc100
disabled auto-merge
July 20, 2026 23:25
sbc100
force-pushed
the
config_vars_expand
branch
from
July 20, 2026 23:25
0d5ffc5 to
e1903c9
Compare
guybedford
pushed a commit
to guybedford/emscripten
that referenced
this pull request
Jul 24, 2026
…7215) This allows us to avoid doing things like `os.path.expanduser` and `os.path.expandvars` inside the config files themselves. This should help pave the way for simplify the config format and one day perhaps making them plain text rather than python scripts. See emscripten-core#27219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to avoid doing things like
os.path.expanduserandos.path.expandvarsinside the config files themselves.This should help pave the way for simplify the config format and one
day perhaps making them plain text rather than python scripts.
See #27219