[test] Move embind benchmark to test/benchmark - #27287
Merged
Merged
Conversation
sbc100
force-pushed
the
embind-benchmark
branch
3 times, most recently
from
July 9, 2026 18:28
81eb784 to
465ac83
Compare
Delete build_benchmark from test/embind, move benchmark files to test/benchmark, and add test_embind to test/test_benchmark.py. This benchmark was added way back in 75881fc. I'm not sure if its useful but that fact that is still compiles after 13 years is a good sign.
brendandahl
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete build_benchmark from test/embind, move benchmark files to test/benchmark, and add test_embind to test/test_benchmark.py.
This benchmark was added way back in 75881fc. I'm not sure if its useful but that fact that is still compiles after 13 years is a good sign.