[test] Add do_benchmarkf and use it for single-file benchmarks#27288
Merged
Conversation
Refactor test_benchmark.py to introduce `do_benchmarkf`, which accepts a source file path on disk. Update `do_benchmark` to write string-based benchmarks to a file and delegate to `do_benchmarkf`. Update all benchmarks with dedicated source files to call `do_benchmarkf` directly instead of reading source contents with `read_file`.
sbc100
force-pushed
the
benchmark-do-benchmarkf
branch
from
July 8, 2026 23:49
ad04e3d to
02226dc
Compare
sbc100
enabled auto-merge (squash)
July 8, 2026 23:50
kripken
approved these changes
Jul 9, 2026
sbc100
disabled auto-merge
July 9, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test_benchmark.py to introduce
do_benchmarkf, which accepts a source file path on disk. Updatedo_benchmarkto write string-based benchmarks to a file and delegate todo_benchmarkf. Update all benchmarks with dedicated source files to calldo_benchmarkfdirectly instead of reading source contents withread_file.