Fix config string parsing for windows pathnames (with backslashes)#27408
Merged
Conversation
dschuff
approved these changes
Jul 23, 2026
sbc100
force-pushed
the
shlex
branch
3 times, most recently
from
July 23, 2026 17:24
1e4a31a to
b4dd4e9
Compare
sbc100
changed the title
Collaborator
Author
|
Update the approach here, because it turns out we do rely on the posix behaviour for quoting arguments with spaces in them |
By using `shlex.shlex(x, posix=True)` and clearing `lexer.escape`, config strings are parsed with POSIX quote handling while allowing Windows paths to be specified with backslashes. See: emscripten-core#27219
sbc100
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
shlex.shlex(x, posix=True)and clearinglexer.escape, configstrings are parsed with POSIX quote handling while allowing Windows
paths to be specified with backslashes.
See: #27219