Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates src/lib/libwebgl.js to support cross-library alias targets by looking them up in LibraryManager.library, and adds a corresponding test test_dylink_glemu_alias in test/test_other.py. Feedback suggests using Object.prototype.hasOwnProperty.call instead of calling hasOwnProperty directly on lib and LibraryManager.library to prevent potential runtime errors if hasOwnProperty is shadowed.
When `recordGLProcAddressGet` processes `LibraryGLEmulation`, alias targets such as `glGenFramebuffers` live in `LibraryGL` (which has already been merged into `LibraryManager.library`), not in `lib`. Check `LibraryManager.library` in addition to `lib` so that targets like `glGenFramebuffers` in `emscripten_glGenFramebuffersOES` are updated to point to `emscripten_glGenFramebuffers`. See: emscripten-core#27852
sbc100
force-pushed
the
fix-gl-emu-alias-targets
branch
from
October 29, 2026 20:39
aabd127 to
952d880
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
recordGLProcAddressGetprocessesLibraryGLEmulation, alias targets such asglGenFramebufferslive inLibraryGL(which has already been merged intoLibraryManager.library), not inlib.Check
LibraryManager.libraryin addition tolibso that targets likeglGenFramebuffersinemscripten_glGenFramebuffersOESare updated to point toemscripten_glGenFramebuffers.See: #27852