Accept abbreviated upper bounds in version ranges - #699
Open
adrien-cotte wants to merge 1 commit into
Open
adrien-cotte wants to merge 1 commit into
adrien-cotte wants to merge 1 commit into
Conversation
Range matching already includes more precise versions of an abbreviated upper bound, but parsing rejects ranges whose lower bound extends that upper bound. Allow these ranges so callers can constrain a minimum version to the same major or minor version without inventing an upper limit. Fixes envmodules#698 Assisted-by: Codex:gpt-6-astra Signed-off-by: Adrien Cotte <adrien.cotte@asplus.fr>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range matching already includes more precise versions of an abbreviated upper bound, but parsing rejects ranges whose lower bound extends that upper bound. Allow these ranges so callers can constrain a minimum version to the same major or minor version without inventing an upper limit.
Fixes #698
Assisted-by: Codex:gpt-6-astra