ts: remove fixtures left behind when quick mode skips a testfile - #701
Open
xdelaruelle wants to merge 1 commit into
Open
xdelaruelle wants to merge 1 commit into
xdelaruelle wants to merge 1 commit into
Conversation
The skip_if_quick_mode procedure returns out of the current testfile, so the cleanup block at its end is not reached. Testfiles creating a fixture directory before this skip point and removing it in this block leave it behind under the testsuite directory after a quick mode run. This is the case of 180-modulepath-ignore.exp and 060-cachebuild-ignore.exp. Accept fixture paths as arguments of skip_if_quick_mode to remove them when tests are skipped, and pass the directory both testfiles need after the skip point. This avoids duplicating their fixture creation block around the skip. Assisted-by: Claude:claude-fable-5-1 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip_if_quick_modereturns out of the current testfile, so the cleanup block at its end never runs. Testfiles that create a fixture directory before this skip point and remove it in that block leave it behind undertestsuite/after amake test QUICKTEST=yrun:mpign1from180-modulepath-ignore.expandmpigncache1from060-cachebuild-ignore.exp.skip_if_quick_modenow accepts fixture paths and removes them when it skips, and both testfiles pass the directory they still need after the skip point. This avoids duplicating their fixture creation block on each side of the skip, as the other testfiles with a smaller fixture do.