Default trace: only strip rollover suffixes in the filename (#1636) - #1638
Merged
Conversation
Follow-up to #1633: the _N rollover strip keyed on the LAST underscore anywhere in the path, so a trace in an underscore-named directory with an unsuffixed file was cut at the directory underscore (/var/opt/my_sql/log/log.trc -> /var/opt/my.trc -> Msg 19049, no events collected). An underscore now only counts as a rollover suffix when it sits after the last path separator, both families, since the collector runs against Windows and Linux targets. Applied to the shared collector and install/29; truth-tabled live on SQL 2022 across nine path shapes. Also carries the review follow-ups from the #1630/#1633 external PRs: - CHANGELOG entries for #1630, #1633, and this fix. - The three CPU comment sites now cite the actual ring-buffer fix (SQL Server 2025 CU1, KB5078298 fix 4796293) instead of implying 2025 RTM, per MS Learn verification. - The #1630 test's DoesNotContain guard normalizes line endings first, so it cannot pass vacuously on a CRLF checkout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Jul 24, 2026
…section Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1636 (the residual edge from #1633): the
_Nrollover strip keyed on the last underscore ANYWHERE in the path, so a relocated default trace in an underscore-named directory with an unsuffixed file mangled to a nonexistent path (/var/opt/my_sql/log/log.trc->/var/opt/my.trc-> Msg 19049 -> zero events). The strip now fires only when the last underscore sits AFTER the last path separator (both\and/, since targets are Windows and Linux). Applied to the shared collector (Lite + Darling) andinstall/29.Also carries the review follow-ups from the #1630/#1633 community PRs: CHANGELOG entries for both plus this fix, the three CPU comment sites now cite the actual ring-buffer fix (SQL Server 2025 CU1, KB5078298 fix 4796293) rather than implying 2025 RTM (verified against MS Learn), and the #1630 test's
DoesNotContainguard normalizes line endings so it cannot pass vacuously on a CRLF checkout.Test plan
🤖 Generated with Claude Code