Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe selector-complexity rule now reports each disallowed attribute occurrence at its own name location. Tests cover repeated attributes and attributes in separate selector compounds. ChangesDisallowed attribute reporting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change gives repeated disallowed attributes diagnostics at their respective locations, and the added tests assert those ranges. No actionable merge-blocking risk remains from the inspected changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prerequisites checklist
AI acknowledgment
What did you do?
What did you expect to happen?
Two errors, one at each
data-fooattribute selector.What actually happened?
Two errors, both reported at
3:2.What is the purpose of this pull request?
This PR makes
selector-complexityreport each disallowed attribute selector at its own location when the same attribute appears more than once in a selector.What changes did you make? (Give an overview)
The
disallowAttributescheck now iterates the attribute selector nodes directly and reports at each node'sname.loc, instead of mapping to names and looking the location up withfind().Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit