fix: address confirmed defects from audit triage - #13
Merged
Merged
Conversation
Fix HTTP TLS double-free and Content-Length overflow, line-framer false positives, JSON uint64 wrap / embedded NUL, Bool KeysEqual, RC4 Final check, NaN map/set ordering, and ini mixed-key sort comparator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSL_CTXdouble-free on Listen failure andContent-Lengthsize_t overflowuint64 > INT64_MAXwraparound and embedded-NUL string truncationKeysEqualusing stale union bytes, RC4 uncheckedEVP_EncryptFinal_ex, NaNContainerKeyordering, and ini mixed-key sort comparatorTest plan
unit_tests --gtest_filter='test_json.*:test_ini.*:test_crypto.*:test_net.*:test_http.*:test_basic.*pairs*:test_container.*'(176 passed)test_json.decode_uint64_overflow,test_json.decode_embedded_nulMade with Cursor