Skip to content

🛡️ Sentinel: [MEDIUM] Fix wildcard injection in get_profile - #4

Closed
euxaristia wants to merge 1 commit into
mainfrom
sentinel-fix-wildcard-injection-3158829998489895964
Closed

🛡️ Sentinel: [MEDIUM] Fix wildcard injection in get_profile#4
euxaristia wants to merge 1 commit into
mainfrom
sentinel-fix-wildcard-injection-3158829998489895964

Conversation

@euxaristia

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
💡 Vulnerability: The get_profile database function in gitlawb-node/src/db/mod.rs was vulnerable to SQL wildcard injection. User-provided did input was directly bound as part of a LIKE pattern (LIKE '%:' || $1). If an attacker provided wildcard characters like % or _, they would not be escaped, causing the query to match unintended rows in the agent_profiles table.
🎯 Impact: Attackers could potentially bypass identity lookups or query other agent profiles when they don't know the full ID.
🔧 Fix: We explicitly escaped %, _, and \ inside the Rust logic by replacing them with \%, \_ and \\ respectively. We then explicitly instructed PostgreSQL to recognize \ as the escape character using ESCAPE '\\'.
✅ Verification: Ran cargo check, cargo fmt, and cargo clippy. No functionality breaks, test suite passes offline checks.


PR created automatically by Jules for task 3158829998489895964 started by @euxaristia

Co-authored-by: euxaristia <25621994+euxaristia@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfd8d7b9-87ab-470c-97b4-439babf57e0f

📥 Commits

Reviewing files that changed from the base of the PR and between c10ccf1 and 159fdc7.

📒 Files selected for processing (2)
  • .jules/sentinel.md
  • crates/gitlawb-node/src/db/mod.rs

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Closing as superseded. get_profile no longer uses LIKE '%:' || $1. Gitlawb#298 switched it to normalize_owner_key / PROFILE_DID_CASE_SQL equality.

@euxaristia euxaristia closed this Aug 18, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded. get_profile no longer uses LIKE '%:' || $1. Gitlawb#298 switched it to normalize_owner_key / PROFILE_DID_CASE_SQL equality.

Understood. Acknowledging that this work is now superseded by Gitlawb#298 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant