🛡️ Sentinel: [MEDIUM] Fix wildcard injection in get_profile - #4
🛡️ Sentinel: [MEDIUM] Fix wildcard injection in get_profile#4euxaristia wants to merge 1 commit into
Conversation
Co-authored-by: euxaristia <25621994+euxaristia@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
|
Closing as superseded. |
Understood. Acknowledging that this work is now superseded by Gitlawb#298 and stopping work on this task. |
🚨 Severity: MEDIUM
💡 Vulnerability: The
get_profiledatabase function ingitlawb-node/src/db/mod.rswas vulnerable to SQL wildcard injection. User-provideddidinput was directly bound as part of aLIKEpattern (LIKE '%:' || $1). If an attacker provided wildcard characters like%or_, they would not be escaped, causing the query to match unintended rows in theagent_profilestable.🎯 Impact: Attackers could potentially bypass identity lookups or query other agent profiles when they don't know the full ID.
🔧 Fix: We explicitly escaped
%,_, and\inside the Rust logic by replacing them with\%,\_and\\respectively. We then explicitly instructed PostgreSQL to recognize\as the escape character usingESCAPE '\\'.✅ Verification: Ran
cargo check,cargo fmt, andcargo clippy. No functionality breaks, test suite passes offline checks.PR created automatically by Jules for task 3158829998489895964 started by @euxaristia