Clarify connected_components candidate vertex semantics - #841
Merged
Merged
Conversation
Co-authored-by: samueltardieu <44656+samueltardieu@users.noreply.github.com>
Copilot
AI
changed the title
Clarify connected_components candidate vertices
Clarify Sep 22, 2026
connected_components candidate vertex semantics
Copilot created this pull request from a session on behalf of
samueltardieu
September 22, 2026 21:16
View session
samueltardieu
marked this pull request as ready for review
September 22, 2026 21:17
samueltardieu
enabled auto-merge
September 22, 2026 21:18
📊 iai-callgrind Benchmark Results➡️ 20 Unchanged (within ±0.1%)Click to expand
✅ All benchmarks unchangediai-callgrind measures instructions executed, which is deterministic and not affected by system load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connected_componentswas easy to misread as a recursive graph traversal from the provided inputs. In practice, the input slice defines the candidate vertices whose neighbour sets are merged; neighbours discovered from those vertices are included in the result but are not recursively expanded unless they are also present in the input.API naming
startstocandidatesto reflect its actual role in the algorithm.Documentation
neighbours.candidates.Tests
In this shape,
0and3are the candidate vertices. Their neighbour sets are merged into a single component, but1and2are not queried unless they are also included in the candidate list.Close #840