fix(edmonds-karp): drop the two unsafe Send impls again - #846
Merged
Merged
Conversation
These were removed in evenfurther#820, since the compiler already derives Send for both types whenever C is Send. evenfurther#823 brought them back by accident: its branch predated evenfurther#820, and landing it restored the old lines. tests/edmondskarp.rs still asserts that both types are Send, which holds without them, as it did after evenfurther#820.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores #820, which fixed #817.
#820 removed two
unsafe impl Sendblocks fromedmonds_karp.rs, because the compiler already derivesSendforSparseCapacity<C>andDenseCapacity<C>wheneverCisSend. They are back onmainbecause of my #823: its branch was cut before #820 was merged, and landing it wrote the old lines back. The same stale branch is what carriedCONTRIB-DRAFTS.mdin, which #828 took out again. Sorry about that.This removes the same two blocks #820 removed, and nothing else.
capacities_are_send_without_an_unsafe_implintests/edmondskarp.rs, added by #820, still passes. It asserts the types areSend, which holds either way, so it could not have caught the regression. I did not add a test that greps the source forunsafe impl, since that seemed out of keeping with the rest of the suite, but I can if you would like one.To check nothing else came back the same way, I went through every commit since #786 and looked for deleted lines that are present in the source again. These two blocks are the only real case; the other matches were lines that had been moved rather than removed.