Skip to content

Feature/922 make permissions configurable for custom workflows#923

Merged
ArBridgeman merged 25 commits into
mainfrom
feature/922_make_permissions_configurable_for_custom_workflows
Jul 15, 2026
Merged

Feature/922 make permissions configurable for custom workflows#923
ArBridgeman merged 25 commits into
mainfrom
feature/922_make_permissions_configurable_for_custom_workflows

Conversation

@ArBridgeman

@ArBridgeman ArBridgeman commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

closes #922

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@ArBridgeman
ArBridgeman force-pushed the feature/922_make_permissions_configurable_for_custom_workflows branch from 10e54e9 to 3b03bca Compare July 10, 2026 08:53
@ArBridgeman
Remove not-maintained workflows from get_workflow_templates - need to…
92a1ae4 
… be handled separately
@ArBridgeman
Remove now unneeded custom exception as not maintained workflows not …
c3d2872 
…in ALL anymore
@ArBridgeman
Remove redundant check
0a36b86 
- This is already present in the CLI of the nox sessions workflow:check and workflow:generate
- This is already required by the WorkflowOrchestrator which is a pydantic model which restricts WorkflowChoice
and hard-code maps it to the right values.
@ArBridgeman
Ensure NOT_MAINTAINED_WORKFLOWS are seeded first
1ac5e10
@ArBridgeman
Tighten wording in documentation
69e8d14
@ArBridgeman
ArBridgeman force-pushed the feature/922_make_permissions_configurable_for_custom_workflows branch from 1eae0d1 to 69e8d14 Compare July 10, 2026 08:58
ArBridgeman
ArBridgeman commented Jul 10, 2026
View reviewed changes
Comment thread exasol/toolbox/util/workflows/workflow_orchestrator.py
@ArBridgeman

ArBridgeman commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 10, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69e8d1492a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread exasol/toolbox/util/workflows/custom_workflow.py
Comment thread exasol/toolbox/util/workflows/custom_workflow.py
kratz00
kratz00 reviewed Jul 13, 2026
View reviewed changes
Comment thread doc/changes/unreleased.md Outdated
Comment thread exasol/toolbox/util/workflows/custom_workflow.py Outdated
ckunki
ckunki previously requested changes Jul 13, 2026
View reviewed changes
Comment thread doc/changes/changes_10.0.0.md Outdated
Comment thread doc/changes/unreleased.md Outdated
Comment thread doc/user_guide/features/github_workflows/workflow_variables.rst Outdated
Comment thread doc/user_guide/features/github_workflows/workflow_variables.rst
Comment thread exasol/toolbox/templates/github/workflows/ci.yml Outdated
Comment thread exasol/toolbox/util/workflows/custom_workflow.py Outdated
Comment thread exasol/toolbox/util/workflows/custom_workflow.py
@ArBridgeman
ArBridgeman force-pushed the feature/922_make_permissions_configurable_for_custom_workflows branch from fa2b11c to 3663d2b Compare July 14, 2026 13:27
@ArBridgeman
ArBridgeman requested review from ckunki and kratz00 July 14, 2026 13:28
@sonarqubecloud

sonarqubecloud Bot commented Jul 14, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ArBridgeman
ArBridgeman enabled auto-merge (squash) July 15, 2026 07:45
@ArBridgeman
ArBridgeman merged commit 827ac61 into main Jul 15, 2026
42 checks passed
@ArBridgeman
ArBridgeman deleted the feature/922_make_permissions_configurable_for_custom_workflows branch July 15, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@kratz00 kratz00 kratz00 approved these changes
@ckunki ckunki ckunki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make permissions configurable for custom workflows

3 participants

@ArBridgeman @kratz00 @ckunki