Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b269f64d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <span | ||
| {...props} | ||
| class="focus-visible:ring-ring inline cursor-help rounded-sm outline-none focus-visible:ring-2 focus-visible:ring-offset-2" |
There was a problem hiding this comment.
When navigating event or stack lists with a keyboard, this custom trigger is a plain <span> without tabindex, so it cannot receive normal Tab focus and the full timestamp remains unavailable. The test's programmatic fireEvent.focus() succeeds even for non-focusable elements and therefore does not cover this scenario; make the trigger natively focusable or explicitly add it to the tab order.
Useful? React with 👍 / 👎.
|
1 participant
Relative timestamps in event and stack lists now expose the full local date and time, including seconds and timezone, on hover or keyboard focus. Compact labels and date-filter boundaries remain unchanged; midnight retains its time component.
Validation: 15 focused formatter/date tests passed;
npm run validatepassed with zero Svelte errors or warnings. Local browser checks against synthetic API data passed for event and stack lists, including hover, keyboard focus, and Escape. Maintainability review found no outstanding issues.No public API changes or breaking changes.