Skip to content

Improve tag autocomplete with bounded cached search - #2584

Open
niemyjski wants to merge 1 commit into
mainfrom
issue/customer-tag-search
Open

niemyjski wants to merge 1 commit into
mainfrom
issue/customer-tag-search

Conversation

@niemyjski

Copy link
Copy Markdown
Member

Tag autocomplete now shows up to 250 organization-wide suggestions and searches beyond that initial set without discarding selected tags. Complete results filter locally; incomplete results use debounced, bounded literal searches through the existing aggregation endpoint. Results are cached for five minutes per session, organization, and search; dashboard filter changes do not refetch suggestions.

Completeness follows the pinned repository's typed bucket metadata and zero-counter omission contract, covered by backend tests. Authorization, retention, premium checks, and public API contracts remain unchanged.

Validation:

  • 11 focused frontend unit tests and 6 backend integration tests passed.
  • 2 browser regressions passed, covering local filtering, debounce, cache reuse, retry, preserved selections, and no requests after date/project changes.
  • Real local API/browser verification found a rare punctuation-containing tag beyond the initial 250.
  • npm run validate passed; maintainability review has no outstanding findings.
  • A small synthetic 2,301-event fixture returned bounded queries in approximately 4–8 ms across five warm runs per query; this is not production-scale load evidence.

No breaking changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T02:43:58.274900Z 1079f1c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1079f1c024

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +71 to +73
if (!open) {
debouncedSearch = '';
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear the search text when closing the tag picker

When a user types a query and closes the picker, this branch clears only debouncedSearch; the bound search state retains the query. Reopening the picker therefore immediately filters the suggestions by the previous text and may launch another remote lookup instead of showing the full tag list as it did previously. Reset search when open becomes false.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286
Exceptionless.Web 85% 70% 8108
Exceptionless.Core 76% 68% 10538
Exceptionless.AppHost 38% 41% 147
Summary 79% (26386 / 33396) 68% (12279 / 18049) 19079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant